add support for common good parachains

[ShankarWarang]

Added common good chains:

• Polkadot AssetHub
• Polkadot BridgeHub
• Polkadot Collectives
• Polkadot Coretime
• Polkadot People
• Kusama AssetHub
• Kusama BridgeHub
• Kusama Coretime
• Encointer Network
• Kusama People

🔗 zboto Link

[emmanuelm41]

Hi @ShankarWarang! Just to confirm, these chains are not levering the new feature in polkadot for the generic, right? Besides, can you please share with us sources you used to set slip0044 and the ss85_addr_type?

[ShankarWarang]

Hi @ShankarWarang! Just to confirm, these chains are not levering the new feature in polkadot for the generic, right? Besides, can you please share with us sources you used to set slip0044 and the ss85_addr_type?

Gm @emmanuelm41 👋
As far as I know, all above common good chains have implemented the necessary changes required for the generic polkadot app, thanks to @bkchr.
Reference: polkadot-fellows/runtimes#337

These common-good parachains share the same slip0044 (same native token) and the ss85_addr_type as their corresponding relaychains (Polkadot & Kusama). I guess this might cause conflict as per the current implementation?

[emmanuelm41]

Gm @ShankarWarang. If they have implemented the feature for the generic polkadot app, then there is no need to add them as done on this PR. What you did is meant for apps that are chain-specific, as before the CheckMetadataHash feature exists. We could merge it anyway, but it is not really necessary.

Supported_apps is just used here...

ledger-substrate-js/src/supported_apps.ts

Lines 22 to 30 in 5732e37

	export function newSubstrateApp(transport: Transport, chainName: string) {
	const requestedApp = supportedApps.find((app: SubstrateAppParams) => {
	return app.name.toLowerCase() === chainName.toLowerCase()
	})
	if (requestedApp != null) {
	return new SubstrateApp(transport, requestedApp.cla, requestedApp.slip0044)
	}
	throw new Error(`Error: ${chainName} not supported`)
	}

While this is the class for the generic app...

ledger-substrate-js/src/generic_app.ts

Lines 57 to 65 in 5732e37

	constructor(transport: Transport, txMetadataChainId?: string, txMetadataSrvUrl?: string) {
	super(transport, PolkadotGenericApp._params)
	this.txMetadataSrvUrl = txMetadataSrvUrl
	this.txMetadataChainId = txMetadataChainId
	if (!this.transport) {
	throw new Error('Transport has not been defined')
	}
	}