chore(deps): update go to v1.22.0 (main) - autoclosed #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Currently, the config property `enforce-ingress-https` doesn't have any effect as its value isn't propagated to the ingresscontroller reconciler. Hence, Ingress HTTPS is never enforced globally (only via annotation). This commit fixes this by passing the config value to the reconciler. Fixes: cilium#30616 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Since "Observable" forks a goroutine that is not tied to the lifecycle of the
application what may occur is that the "observe" goroutine calls DeleteTracker.Close
after DB.Stop, leading to:
panic: send on closed channel
goroutine 106 [running]:
github.com/cilium/cilium/pkg/statedb.(*DeleteTracker[...]).Close(0x0)
/host/pkg/statedb/deletetracker.go:76 +0x21e
While it would be ideal that goroutines created by statedb would be tied to its lifecycle
and thus Stop() could wait for e.g. all observable goroutines to be finished, it's not
enough as DeleteTracker's may be created outside and stopped after DB. Thus this commit
changes the logic to make it safe to call DeleteTracker.Close() even after the DB has
stopped.
The fix was validated by adding a "defer time.Sleep(100*time.Millisecond)" to observable.go
before the "tracker.Close()" to force it to run after DB.Stop, with it failing with
"send on closed channel" before fix and passing after.
As a future follow-up it would make sense to use a Hive job group tied to DB's
lifecycle to make sure all goroutines are cleaned up (this follow-up will be done against
the cilium/statedb repo as it's being moved there). The fix in this commit is already
part of cilium/statedb repo and does not need to be ported.
Fixes: cilium#30806
Fixes: 23b0492 ("statedb2: StateDB v2.0 with per-table locks and deletion tracking")
Signed-off-by: Jussi Maki <jussi@isovalent.com>
In Go 1.22, slices.CompactFunc will clear the slice elements that got discarded. This makes TestSortedUniqueFunc fail if it is run in succession to other tests modifying the input slice. Avoid this case by not modifying the input slice in the test case but make a copy for the sake of the test. Signed-off-by: Tobias Klauser <tobias@cilium.io>
Currently, Cilium attaches SBOMs to images using
cosign attach sbom --sbom sbom.spdx quay.io/${{ env.QUAY_ORGANIZATION }}/${{ matrix.name }}@${{ steps.docker_build_release.outputs.digest }}
during build images workflows.
This raises the following warning:
---
WARNING: SBOM attachments are deprecated and support will be removed
in a Cosign release soon after 2024-02-22 (see sigstore/cosign#2755).
Instead, please use SBOM attestations.
---
Cilium build image workflows need to migrate to using cosign attest
Fixes: cilium#30664
Signed-off-by: Umesh Keerthy <umesh.freelance@gmail.com>
This reverts commit dbc52a0. Signed-off-by: André Martins <andre@cilium.io>
This bitwise lpm trie is a non-thread-safe binary trie that indexes arbitrarily long bit-based keys with associated prefixes indexed from most significant bit to least significant bit using the longest prefix match algorithm. Documenting the behavior of the datastructure is localized around the method calls in the trie.go file. The tests specifically test boundary cases for the various methods and fuzzes the RangeLookup method. Updating CODEOWNERS to put sig-policy and ipcache in charge of this library. Fixes: cilium#29519 Co-authored-by: Casey Callendrello <cdc@isovalent.com> Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This commit updates the Ariane configuration to include the GitHub organization team 'organization-members' in the list of allowed teams. Consequently, only members of this specific team will have the authorization to initiate test runs via issue comments. Signed-off-by: Birol Bilgin <birol@cilium.io>
This commit adds the 'failed to list CRDs' log - "the server could not find the requested resource" - to the list of accepted warning logs. This message is already in the list of ignored error logs, however this message can also appear as a warning log from klog. Fixes: cilium#30776 Related: cilium#26591 Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
Let's make it easier for users to tell us about regressions. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When renovate is upgrading a major version of two dependencies, they don't need to be put into separate PRs. Instead, use renovate to use the same PR for both upgrades. Signed-off-by: André Martins <andre@cilium.io>
Group the updates of each of these two images together so that we don't have a PR for each version type. For example, we don't need to have a PR for a digest change together with an update for minor, we can simply have the minor update instead. Signed-off-by: André Martins <andre@cilium.io>
This dependency should be grouped in one PR for the same updates and it should be updated for older branches for major and or minor versions. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: renovate[bot] <bot@renovateapp.com>
renovate
bot
changed the title
renovate
bot
changed the title
aanm
force-pushed
the
main
branch
3 times, most recently
from
8efcc9c
to
b8dd021
Compare
renovate
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.21.6->1.22.01.21.6->1.22.01.21.0->1.22.01.21.6->1.22.0Release Notes
golang/go (go)
v1.22.0v1.21.7v1.21.6v1.21.5v1.21.4v1.21.3v1.21.2v1.21.1Configuration
📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.