Added support for visual studio 2017 to fix #19 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #19. VS 2017 is version 15.x. The previous version range was [11.0,15.0] which means 11.0 <= VS version <= 15.0. This failed when version 15.1 came out. I've changed this to [11.0,16.0) which means. 11.0 <= VS version < 16.0 so it will work for all updates to VS 2017 but won't work for the next major version update.
|
@martingbrown Why did you close this PR? It's not actually merged in. |
|
Because the patch doesn't actually work. I forget why, but its not that simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #19.
VS 2017 is version 15.x. The previous version range was [11.0,15.0] which means 11.0 <= VS version <= 15.0. This failed when version 15.1 came out. I've changed this to [11.0,16.0) which means. 11.0 <= VS version < 16.0 so it will work for all updates to VS 2017 but won't work for the next major version update.