feat: refactor frozen warnings #1141
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { ExclamationIcon } from '@heroicons/react/outline'; | ||
| import { Trans } from '@lingui/macro'; | ||
| import { Box, SvgIcon } from '@mui/material'; | ||
|
|
||
| import { ContentWithTooltip } from '../ContentWithTooltip'; | ||
| import { Link } from '../primitives/Link'; | ||
| import { frozenProposalMap } from '../../utils/marketsAndNetworksConfig'; | ||
|
|
||
| interface FrozenTooltipProps { | ||
| symbol?: string; | ||
| currentMarket?: string; | ||
| } | ||
|
|
||
| export const getFrozenProposalLink = ( | ||
| symbol: string | undefined, | ||
| currentMarket: string | undefined | ||
| ): string => { | ||
| if (currentMarket && currentMarket === 'proto_harmony_v3') { | ||
| return 'https://snapshot.org/#/aave.eth/proposal/0x81a78109941e5e0ac6cb5ebf82597c839c20ad6821a8c3ff063dba39032533d4'; | ||
| } else if (currentMarket && currentMarket === 'proto_fantom_v3') { | ||
| return 'https://snapshot.org/#/aave.eth/proposal/0xeefcd76e523391a14cfd0a79b531ea0a3faf0eb4a058e255fac13a2d224cc647'; | ||
| } else if (symbol && frozenProposalMap[symbol]) { | ||
| return frozenProposalMap[symbol]; | ||
| } else { | ||
| return 'https://app.aave.com/governance'; | ||
| } | ||
| }; | ||
|
|
||
| export const FrozenTooltip = ({ symbol, currentMarket }: FrozenTooltipProps) => { | ||
| return ( | ||
| <ContentWithTooltip | ||
| tooltipContent={ | ||
| <Box> | ||
| <Trans> | ||
| This asset is frozen due to an Aave Protocol Governance decision.{' '} | ||
| <Link | ||
| href={getFrozenProposalLink(symbol, currentMarket)} | ||
| sx={{ textDecoration: 'underline' }} | ||
| > | ||
| <Trans>More details</Trans> | ||
| </Link> | ||
| </Trans> | ||
| </Box> | ||
| } | ||
| > | ||
| <SvgIcon sx={{ fontSize: '20px', color: 'error.main', ml: 2 }}> | ||
| <ExclamationIcon /> | ||
| </SvgIcon> | ||
| </ContentWithTooltip> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { Trans } from '@lingui/macro'; | ||
| import { Link, Typography } from '@mui/material'; | ||
|
|
||
| import { Warning } from '../../primitives/Warning'; | ||
|
|
||
| const WarningMessage = ({ market }: { market: string }) => { | ||
| if (market === 'Harmony') { | ||
| return ( | ||
| <Trans> | ||
| Due to the Horizon bridge exploit, certain assets on the Harmony network are not at parity | ||
| with Ethereum, which affects the Aave V3 Harmony market. | ||
| </Trans> | ||
| ); | ||
| } else if (market === 'Fantom') { | ||
| return <Trans>Per the community, the Fantom market has been frozen.</Trans>; | ||
| } else { | ||
| return <></>; | ||
| } | ||
| }; | ||
|
|
||
| const getLink = (market: string, forum: boolean | undefined): string => { | ||
| if (market === 'Harmony') { | ||
| if (forum) { | ||
| return 'https://governance.aave.com/t/harmony-horizon-bridge-exploit-consequences-to-aave-v3-harmony/8614'; | ||
| } else { | ||
| return 'https://snapshot.org/#/aave.eth/proposal/0x81a78109941e5e0ac6cb5ebf82597c839c20ad6821a8c3ff063dba39032533d4'; | ||
| } | ||
| } else if (market === 'Fantom') { | ||
| if (forum) { | ||
| return 'https://governance.aave.com/t/arc-aave-v3-fantom-freeze-reserves/9166'; | ||
| } else { | ||
| return 'https://snapshot.org/#/aave.eth/proposal/0xeefcd76e523391a14cfd0a79b531ea0a3faf0eb4a058e255fac13a2d224cc647'; | ||
|
There was a problem hiding this comment. Similarly. I think we should create a There was a problem hiding this comment. Also will be covered in other comment ^ There was a problem hiding this comment. Once we get that file setup, we could setup a mapping of market name to proposal info. Then I think in the asset list components we wouldn't need to do any checking of market name, we just look up in the mapping by market name, if it's empty don't render. Could help clean up some of those if statements in the other pages. |
||
| } | ||
| } else { | ||
| return ''; | ||
| } | ||
| }; | ||
|
|
||
| interface MarketWarningProps { | ||
| marketName: string; | ||
| forum?: boolean; | ||
| } | ||
|
|
||
| export const MarketWarning = ({ marketName, forum }: MarketWarningProps) => { | ||
| return ( | ||
| <Warning severity="error"> | ||
| <Typography variant="caption"> | ||
| <WarningMessage market={marketName} />{' '} | ||
| <Link href={getLink(marketName, forum)} target="_blank"> | ||
| {forum ? <Trans>Join the community discussion</Trans> : <Trans>Learn more</Trans>} | ||
| </Link> | ||
| </Typography> | ||
| </Warning> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small optimization if you wanted to, you could assign the baseUrl to a var for DRY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I'll just keep it as is, but I opened aave/aave-utilities#419 to create an enum so we don't have to hardcode the market names, and we can move these links to a separate config (either in utilities or interface) as well when this is added.