Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add "Supply WBTC, Borrow USDT" Merit APR [skip cypress] #2232

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

MartinGbz
Copy link
Contributor

General Changes

This PR add the APR of a new upcoming Merit program: "Supply WBTC, Borrow USDT"
This program incentives users that Supply WBTC AND Borrow USDT (like cbBTC/USDC, both actions are required to get the incentives). The program is paid in aUSDT.

Developer Notes

We are currently working on the implementation of the program, it will be ready soon. In the mean time, I mocked the APR at 5%.

Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@MartinGbz MartinGbz changed the title ✨ Add "Supply WBTC, Borrow USDT" Merit APRs ✨ Add "Supply WBTC, Borrow USDT" Merit APR Oct 28, 2024
Copy link

github-actions bot commented Oct 30, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/11592044746'

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 542.79 KB (🟢 -154 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 47.89 KB (🟡 +60 B) 590.68 KB
/bridge 36.21 KB (🟢 -25 B) 579 KB
/markets 27.55 KB (🟡 +60 B) 570.34 KB
/staking 22.82 KB (🟡 +60 B) 565.61 KB
/v3-migration 29.95 KB (🟡 +60 B) 572.74 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

@foodaka foodaka changed the title ✨ Add "Supply WBTC, Borrow USDT" Merit APR ✨ Add "Supply WBTC, Borrow USDT" Merit APR [skip cypress] Oct 30, 2024
@foodaka foodaka merged commit 5233c53 into aave:main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants