-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user-installables #1532
base: dev
Are you sure you want to change the base?
feat: user-installables #1532
Conversation
I have not tested this feature yet so the pull request will be a draft for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please lint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing ApplicationCommand typings. Also when you lint, please use the script provided in package.json
Co-authored-by: bsian03 <chharry321@gmail.com>
(again: prettier added the commans for some reason)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i spent 5 months trying to sort everything alphabetically/in a sensible easy-to-understand order in a previous pr, please make sure it's the same here :)
And still missing ApplicationCommand typings |
How do you suggest I could make it more sensible? Also, are there any other properties that needs to be alphabetically sorted? I would like to tackle these in a single day rather than a back and forth. |
chore(lint): add missing space
This pull requests adds the ability to configure application command context which allows the creation of user-installable commands.