Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user-installables #1532

Open
wants to merge 36 commits into
base: dev
Choose a base branch
from
Open

Conversation

retrouser955
Copy link

@retrouser955 retrouser955 commented Aug 25, 2024

This pull requests adds the ability to configure application command context which allows the creation of user-installable commands.

@retrouser955 retrouser955 marked this pull request as draft August 25, 2024 07:32
@retrouser955
Copy link
Author

I have not tested this feature yet so the pull request will be a draft for now.

@retrouser955
Copy link
Author

retrouser955 commented Aug 25, 2024

Hey, I just have a couple of questions. Would you add the context of the application command usage CommandInteraction or CommandInteractionData?

Right now, I have it set to the former and I was just checking if changes are needed.
image

Edit: Question answered via Discord

@retrouser955 retrouser955 marked this pull request as ready for review August 25, 2024 15:35
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please lint.

lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ApplicationCommand typings. Also when you lint, please use the script provided in package.json

index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
examples/userCommand.js Outdated Show resolved Hide resolved
lib/Client.js Outdated Show resolved Hide resolved
lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@bsian03 bsian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i spent 5 months trying to sort everything alphabetically/in a sensible easy-to-understand order in a previous pr, please make sure it's the same here :)

lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/Constants.js Outdated Show resolved Hide resolved
@bsian03
Copy link
Collaborator

bsian03 commented Aug 26, 2024

And still missing ApplicationCommand typings

@retrouser955
Copy link
Author

i spent 5 months trying to sort everything alphabetically/in a sensible easy-to-understand order in a previous pr, please make sure it's the same here :)

How do you suggest I could make it more sensible? Also, are there any other properties that needs to be alphabetically sorted? I would like to tackle these in a single day rather than a back and forth.

@retrouser955 retrouser955 changed the title Add user-installable commands to eris feat: user-installables Aug 27, 2024
lib/structures/CommandInteraction.js Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
index.d.ts Show resolved Hide resolved
index.d.ts Outdated Show resolved Hide resolved
lib/structures/AutocompleteInteraction.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants