Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for clangd customization #500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nilsdeppe
Copy link

Thanks so much for creating and maintaining emacs-ycmd! I really appreciate it!

YCMD now has experimental support for using clangd as the completer. This PR adds support for customizing the JSON file sent to YCMD with the clangd-specific options.

I'm not sure if or how this should be tested so I would really appreciate feedback on that.

Thanks!

@abingham
Copy link
Owner

abingham commented Dec 6, 2019

I'm no longer using or actively maintaining this package. The patch you've provided looks reasonable on quick inspection, and I'd be happy to merge it in if you think it's correct. Let me know.

@nilsdeppe
Copy link
Author

@abingham Okay, I'm going to check that the clang_args are being passed correctly, but other than that I'm confident it works. I just saw the issue about someone taking over this extension. I'll give it some thought but can probably help do some maintenance and compatibility work, though I'm far from a lisp expert :)

@abingham
Copy link
Owner

I'm going to check that the clang_args are being passed correctly,

Just let me know when you think it's ready to merge, and I'll take care of it.

though I'm far from a lisp expert :)

Believe me, I knew very little about emacs lisp when I started writing extensions. The best way to learn was to dive in. It's a lot of fun (and a little crazy)!

@nilsdeppe
Copy link
Author

@abingham sorry for the delay on this. I just found time to double check things. I made some adjustments to the implementation so it matches what is currently done in the repo. I tested and it works.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants