1130 meeting announcement remaining backend issue list #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Engineer-JJHaMa
requested changes
Oct 12, 2024
There was a problem hiding this comment.
❗ meeting 스키마에 몇가지 변경이 있어 적용해야 합니다.
- enum -> meeting_type_enum 으로 컬럼명 변경
- tag -> meeting_group_tag 로 컬럼명 변경
- 이제 더 이상 enum 테이블을 만들고 외래키를 설정하지 않습니다. enum 컬럼에 걸린 외래키를 제거해 주세요
There was a problem hiding this comment.
❗ meeting 하단에 announcement 모듈을 만들어서 전부 옮기야 합니다!
There was a problem hiding this comment.
👍 👍 로직 자체는 큰 문제가 없어 보입니다!
There was a problem hiding this comment.
❗ meeting 모듈 하위에 anouncement 모듈을 만들어서 전부 옮겨야 할거 같아요!
There was a problem hiding this comment.
💬 MEE-001의 입력 중 tag 는 클라이언트가 입력하는 것이 아닌 분과회의를 그룹핑하기 위한 요소입니다. 입력에서 없애는게 좋아 보여요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #1130
현재 새로 작업이 된 Meeting 관련 Schema하고 이미 개발되어 있는 meeting controller / drizzle schema 사이에 차이가 꽤나 있었습니다
MEE001 - 004에 지원하는 기능들에 각각이 정상 작동하도록 리팩토링 / schema에 coulmn 추가 / 변경을 진행했습니다.
추가 ) MEE001은 이제 생성된 공고에 대한 id를 return 하도록 기능을 추가했습니다.
혹시 다른 문제가 발생하는 지 알려주시면 추가적으로 작업하겠습니다,
우선 가능한대로 API는 최신화를 시켜두어서 기능 작동 여부를 테스트해주시고 피드백 해주시면 감사하겠습니다..!
스크린샷
이후 Task *