New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /credits #26

Open

malloc3141 wants to merge 1 commit into dev from 19-impl-credits-page

Contributor

malloc3141 commented Oct 14, 2024 •

edited

Loading

요약 *

It closes #19

피그마: https://www.figma.com/design/PpSN8r1RC76W0cfSGi1tMD/ar-007-Students?node-id=402-3332&node-type=frame&t=1fQCyofCNNSvJ9zV-0
구현하면서 생긴 디자인 관련 의견은 피그마 페이지에 달아두었습니다.

구현된 사항

credits 페이지
포지션에 호버하면 뜨는 코멘트 같은거는 임시로 닉네임으로 채워두었음
font type이랑 weight 필요한 거 추가(fonts.ts)
스팍스 컬러 상수 colors.ts에 추가
footer에서 만든 사람들 누르면 /credits로 이동

확인해야 할 사항

디자인 상 BreadCrumb이 없는데 실제 페이지에도 필요 없는건지

스크린샷

이후 Task *

없음


          feat: impl /credits

5b4a3fb

malloc3141 added enhancement frontend labels

malloc3141 requested a review from wjeongchoi

October 14, 2024 17:13

malloc3141 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement frontend