1st FE seminar HW : casio #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjeongchoi
reviewed
Jul 27, 2024
| placeholder="" | ||
| value = {textValue} | ||
| handleChange={(value : string) => {setTextValue(value);}} | ||
| ></TextInput> |
There was a problem hiding this comment.
Prettier가 vscode에 안 깔려있다면 온보딩 문서 보고 깔도록 합시다!
| import React, {useState} from "react" | ||
|
|
||
| import TextInput from "@sparcs-clubs/web/common/components/casio/TextInput"; | ||
| import ItemNumberInput from "@sparcs-clubs/web/common/components/Forms/ItemNumberInput"; |
There was a problem hiding this comment.
기본 forms에서 가져다 쓴 것 같은데 이번 과제에서는 본인이 직접 구현한 컴포넌트로 import 해주세요!
| errorMessage?: string; | ||
| handleChange: (value: string) => void; | ||
| setErrorStatus: (hasError: boolean) => void; | ||
| } |
There was a problem hiding this comment.
옆에 개수 제한 & 단위 뜨는 것도 추가해봅시다!
Comment on lines
+55
to
+60
| const InputWrapper = styled.div` | ||
| width: 100%; | ||
| flex-direction: column; | ||
| display: flex; | ||
| gap: 4px; | ||
| `; |
There was a problem hiding this comment.
이건 FlexWrapper로 대체할 수 있어요!
| border-color: ${({ theme }) => theme.colors.GRAY[200]}; | ||
| `; | ||
|
|
||
| const Input = styled.input<{ hasError: boolean }>` |
There was a problem hiding this comment.
shouldForwardProp 없이 이렇게만 넘겨주면 콘솔에 경고가 뜹니다! 프론트 다른 코드 찾아보고 고쳐봅시다
Comment on lines
+59
to
+64
| const InputWrapper = styled.div` | ||
| width: 100%; | ||
| flex-direction: column; | ||
| display: flex; | ||
| gap: 4px; | ||
| `; |
There was a problem hiding this comment.
요것도 FlexWrapper로 대체 될거에요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.