Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR for custom bot for Concerto #434

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Kavisha4
Copy link

@Kavisha4 Kavisha4 commented Mar 25, 2024

Signed-off-by: Kavisha4 kvsha2002@gmail.com
custom bot is integrated for Concerto Model

Closes

This is to propose the idea 2, so anyone who reads the code architecture and documentation should be aware of the change

Changes

  • What is an ADR?

  • An architectural decision record (ADR) is a document that describes a choice the team makes about a significant aspect of the software architecture they're planning to build. Each ADR describes the architectural decision, its context, and its consequences. ADRs have states and therefore follow a lifecycle.

  • I have proposed an ADR for the issue 2 in GSoC 2024 list : Ideas List

Flags

  • Code doesn't break
  • Simple markdown file

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: Kavisha4 <kvsha2002@gmail.com>
custom bot is integrated
Signed-off-by: Kavisha4 <kvsha2002@gmail.com>
@sanketshevkar
Copy link
Member

Hi @Kavisha4
I'm a unsure if this doc should reside in techdocs/docs. Can you please elaborate on why do you wish this doc at that location?

@Kavisha4
Copy link
Author

Kavisha4 commented Mar 28, 2024

Hi @Kavisha4 I'm a unsure if this doc should reside in techdocs/docs. Can you please elaborate on why do you wish this doc at that location?

Hi @sanketshevkar I want to work on "Model Creation AI Assistant (Co-Pilot)" which uses the concerto repository.

Reasons why I have added it here

  1. An ADR essentially tells us which path we decided to follow at cross roads and why. In this case, as I will be highlighting in my proposal as well, its better to integrate chatbots from Dialogflow or Bard, than train an ML model in python from scratch.
  2. Since this is an ADR which tells us about the document, architecture and design of our project
  3. It seemed like an apt repository where decisions were getting documented, although I could also add this markdown file as a part of the Accord repository by creating a new "Docs"-> "Architecture"-> "Design"->"ADR for custom chat bot"

@sanketshevkar
Copy link
Member

@Kavisha4 we'd like to add documentation to tech-docs once the product is ready. If you'd like to discuss design, feel free to create an issue in concerto repo.

@Kavisha4
Copy link
Author

Kavisha4 commented Apr 2, 2024

@Kavisha4 we'd like to add documentation to tech-docs once the product is ready. If you'd like to discuss design, feel free to create an issue in concerto repo.

Sure @sanketshevkar, will add this in my proposal, I have sent you my proposal on discord for feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants