Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting errors in the markdown editor package #287

Closed
wants to merge 1 commit into from

Conversation

Cronus1007
Copy link
Contributor

Closes #52

Description

  • The linting configs were not passed to the package and required a little bit of manual error detection
  • It focusses upon resolving the linting errors in the package.

Screenshots or Video

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: Cronus1007 <lit2019058@iiitl.ac.in>
@Cronus1007
Copy link
Contributor Author

@irmerk The PR completely doesn't solve the issue. For completion have a look upon this comment as well #52 (comment)

@jolanglinais
Copy link
Member

I think linting should be handled from accordproject/techdocs#308 first.

@Cronus1007 Cronus1007 deleted the issue-52 branch March 10, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies Cleanup
2 participants