enable opening workshops and directories in github #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
StoneT2000
approved these changes
May 25, 2022
| @@ -1,6 +1,6 @@ | |||
| .grid { | |||
| display: grid; | |||
| grid-template-columns: repeat(auto-fill, min(100%, minmax(360px , 1fr))); // TODO | |||
| grid-template-columns: repeat(auto-fill, minmax(360px , 1fr)); // TODO | |||
| @@ -0,0 +1,39 @@ | |||
| import { useMemo } from "react" | |||
There was a problem hiding this comment.
small nit but we could turn open in X a component in itself. Basically accepts a url generator and icon. But i think we're only ever gonna do github and colab really so it's probably fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation
atm we're linking people to our github repository for information - this is especially relevant since we've got some pretty decked out READMEs for workshops now. This means it's harder to discover this website, though.
This PR makes it so we can provide a link to the website and people who want to check out the GitHub will still be able to go there easily.
Going into the future, we could look into parsing the README of intermediary directories as well and use that as the page contents instead of the children grid (as the sidebar provides navigation anyway), and only use the children grid as a fallback. Doing this would make the website viewing experience even more integrated and probably round off any major discrepancies between the website and the github repo outside of rendering Jupyter separate cells and outputs (see #7, #9)
what it does
in a similar vein to the "Open in Colab" button, this provides a link for users to navigate directly to the corresponding directory or file in this GitHub repository.
also: proper git usage would mean doing this in a separate pr but i fixed a css bug with displaying the category items here as well