Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right sidebar transition #321

Closed
2 tasks done
andrewtavis opened this issue Aug 30, 2023 · 3 comments
Closed
2 tasks done

Right sidebar transition #321

andrewtavis opened this issue Aug 30, 2023 · 3 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Currently we have the right sidebar for mobile that houses the theme and language selectors. Something that needs to be added is a transition that occurs when someone opens the sidebar. Whether or not there should be a transition for it being closed or it should be closed instantaneously is still up for discussion. For the transition we could use a similar transition as the left sidebar component and its underlying components.

Contribution

This is a great good first issue for someone who's new to the community. Happy to support someone who has interest in working on this!

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Aug 30, 2023
@oneminch
Copy link
Contributor

I can work on this. What kind of transition are looking to add? The website doesn't have a left sidebar for unregistered users.

@andrewtavis
Copy link
Member Author

Hey @oneminch 👋 Thanks for offering to help and your interest in activist. We’re super early stage and don’t have registration yet anyway. You can see the left sidebar if you were to go to activist.org/home on a desktop browser :) We’re testing on this page and a few others.

As far as the transition, you can check SidebarLeftHeader for the way we define the transition there :)

Assigning you now! Please let me know if you have further questions 😊

@andrewtavis
Copy link
Member Author

Closed via #335 and b656ffe :) @oneminch, the big thing that went through in my changes is we needed to re-hide the menu options if the menu's not open as if they're not hidden then the tab controls reach them 😊 Thanks so much for the work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants