Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): #321 Add right sidebar transition #335

Merged
merged 1 commit into from
Sep 5, 2023
Merged

feat(ui): #321 Add right sidebar transition #335

merged 1 commit into from
Sep 5, 2023

Conversation

oneminch
Copy link
Contributor

@oneminch oneminch commented Sep 1, 2023

Contributor checklist


Description

According to #321, the right sidebar for mobile that houses the theme and language selectors doesn't have a transition when toggled. I have added a transition similar to the left sidebar component.

Related issue

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit fc8147d
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/64f250ef5ec571000854bdc6
😎 Deploy Preview https://deploy-preview-335--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@andrewtavis andrewtavis self-requested a review September 3, 2023 18:47
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here, @oneminch! I'll do some minor edits to get the width of the sidebar back to what it was, but this is great stuff! 😊

@andrewtavis andrewtavis merged commit 812e7be into activist-org:main Sep 5, 2023
6 of 8 checks passed
@andrewtavis andrewtavis mentioned this pull request Sep 5, 2023
2 tasks
@oneminch
Copy link
Contributor Author

oneminch commented Sep 5, 2023

No problem. Can't wait to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants