-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#228 test to see if the typecheck will work #309
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
Heyooo @TeddyGavi! 😊 So this has been a bit of a mess of trying things in the workflow and then opening new PRs, but I think this might work. What we were going for here was to be able to check the TypeScript errors while still being able to see a deploy preview from Netlify, and that's exactly what we have here 🥳 See the workflow file for details. Thing is that the deploy preview needed to be triggered manually, but maybe it's just because Netlify was sick and tired of getting requests from this branch as #304 did originally get a preview and none of the ones after did :) Let's see how this goes when the next PR comes through and then if all goes well we can close #228 🚀 |
Closing this and we'll wait on another PR :) |
@andrewtavis Yes! This is exactly what I imagined. I did not fully understand how to implement it and I will study what you have done. Thank you for this and keeping me in the loop. 👍 |
Happy to keep you in the loop, @TeddyGavi! 😊 |
Contributor checklist
Description
Note that this is a test to see if the typecheck works.
Related issue
yarn nuxi typecheck
topackage.json
#228