-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve full chain pulls by enabling Fatras interactions #2086
Conversation
📊 Physics performance monitoring for b24e16eSummary VertexingSeedingCKFAmbiguity resolutionTruth tracking (Kalman Filter)Truth tracking (GSF) |
Codecov Report
@@ Coverage Diff @@
## main #2086 +/- ##
=======================================
Coverage 49.51% 49.51%
=======================================
Files 450 450
Lines 25465 25465
Branches 11718 11718
=======================================
Hits 12608 12608
Misses 4565 4565
Partials 8292 8292 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
somehow this crashes a bunch of things. need to take a closer look |
after discussion with @pbutti I decided to split this PR into smaller pieces |
I pulled this out of #2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion in today's stand-up meeting: Let's get that in!
I pulled this out of acts-project#2086 since it is not relevant there but I would still like to merge them. These changes are random improvements across the code base which should not have any effects on CPU or physics performance.
…roject#2086) Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution. Fixes - acts-project#1643 Blocked by - acts-project#2157 - acts-project#2239 - acts-project#2295 - acts-project#2293 - acts-project#2294
An initial track parameter covariance is necessary to avoid double counting and to estimate the covariance purely from the measurements. Pulled out of acts-project#2086 to see the individual effects. I added this to the ODD and ITk full chain and our physmon bocked by - acts-project#2829
Our full chain pulls are in a bad state. Looks like the reconstruction and simulation energy loss did not match up. This PR switches the Fatras interactions on which should bring our pulls back to standard normal distribution.
Fixes
Blocked by
LineSurface
tolerance inconsistency inglobalToLocal
#2239