chore: Rearrange res/err/pull and use std::sqrt in RootTrajectoryStatesWriter
#2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2307 +/- ##
=======================================
Coverage 49.31% 49.31%
=======================================
Files 447 447
Lines 25153 25153
Branches 11570 11570
=======================================
Hits 12405 12405
Misses 4558 4558
Partials 8190 8190 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for a7c6dbeSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
acts-project-service
added
the
Fails Athena tests
|
Failure seems un-related. There is a problem with the |
CarloVarni
removed
the
Fails Athena tests
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 24, 2023
…yStatesWriter` (acts-project#2307) Minor (IMO) improvements to `RootTrajectoryStatesWriter`: align order of `res`, `err` and `pull` and use `std::sqrt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor (IMO) improvements to
RootTrajectoryStatesWriter: align order ofres,errandpulland usestd::sqrt