Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Explicit and type safe surface candidates delegates for new detector navigation #2316

Closed

draft

140750e
Select commit
Loading
Failed to load commit list.
Closed

refactor: Explicit and type safe surface candidates delegates for new detector navigation #2316

draft
140750e
Select commit
Loading
Failed to load commit list.
ci-bridge / CI Bridge / build_linux_ubuntu failed Jul 24, 2023 in 55s

GitLab CI: FAILED

This check triggered job acts/ci-bridge/31258158
in pipeline acts/ci-bridge/9899
Status: FAILED
Created at: 2023-07-24T16:04:24.384+02:00
Started at: 2023-07-24T16:04:28.285+02:00
Finished at: 2023-07-24T16:05:23.800+02:00

Details

Running with gitlab-runner 15.0.0 (febb2a09)
  on acts-dev-rd-et n2nPuN9T
section_start:1690207468:resolve_secrets
Resolving secrets
section_end:1690207468:resolve_secrets
section_start:1690207468:prepare_executor
Preparing the "docker" executor
Using Docker executor with image ghcr.io/acts-project/ubuntu2204:v41 ...
Pulling docker image ghcr.io/acts-project/ubuntu2204:v41 ...
Using docker image sha256:25d587b5480df92cfc0ad50a203d396645fbdbd30028f181d9772f092d3b97b1 for ghcr.io/acts-project/ubuntu2204:v41 with digest
ghcr.io/acts-project/ubuntu2204@sha256:04d03acdbeb619ee3e35de782c8daf767dfc479b2621d283f8f309c86c991638 ...
section_end:1690207470:prepare_executor
section_start:1690207470:prepare_script
Preparing environment
Running on runner-n2npun9t-project-132265-concurrent-1 via 20742883de13...
section_end:1690207470:prepare_script
section_start:1690207470:get_sources
Getting source from Git repository
Fetching changes with git depth set to 20...
Reinitialized existing Git repository in /builds/acts/ci-bridge/.git/
Checking out 12b1957a as main...
Removing build/
Removing ccache/
Removing src/

Skipping Git submodules setup
section_end:1690207472:get_sources
section_start:1690207472:restore_cache
Restoring cache
Checking cache for ccache-build-linux-ubuntu-newnav-typesafe-surfaceprovider-r1-1-protected...
WARNING: file does not exist                       
Failed to extract cache
section_end:1690207472:restore_cache
section_start:1690207472:step_script
Executing "step_script" stage of the job script
Using docker image sha256:25d587b5480df92cfc0ad50a203d396645fbdbd30028f181d9772f092d3b97b1 for ghcr.io/acts-project/ubuntu2204:v41 with digest
ghcr.io/acts-project/ubuntu2204@sha256:04d03acdbeb619ee3e35de782c8daf767dfc479b2621d283f8f309c86c991638 ...
$ echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
$ git clone $CLONE_URL src
Cloning into 'src'...
$ cd src
$ git checkout $HEAD_SHA
Note: switching to '140750eb33efd459626fb5edc4c287ea39ab61d3'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 140750eb3 draft
$ git submodule init
Submodule 'thirdparty/OpenDataDetector' (https://gitlab.cern.ch/acts/OpenDataDetector.git) registered for path 'thirdparty/OpenDataDetector'
$ git submodule update
Cloning into '/builds/acts/ci-bridge/src/thirdparty/OpenDataDetector'...
Submodule path 'thirdparty/OpenDataDetector': checked out 'e3b1eceae96fd5dddf10223753964c570ee868c9'
$ cd ..
$ mkdir build
$ cmake -B build -S src -GNinja -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_CXX_FLAGS=-Werror
-DCMAKE_CXX_STANDARD=17 -DACTS_ENABLE_LOG_FAILURE_THRESHOLD=ON  -DACTS_BUILD_EVERYTHING=ON -DACTS_BUILD_ODD=ON
-DACTS_BUILD_EXAMPLES_PYTHON_BINDINGS=ON -DACTS_BUILD_EXAMPLES_BINARIES=ON -DACTS_BUILD_EXAMPLES_EDM4HEP=ON -DACTS_FORCE_ASSERTIONS=ON
-DACTS_BUILD_ANALYSIS_APPS=ON -DACTS_BUILD_PLUGIN_ONNX=ON -DACTS_BUILD_PLUGIN_ACTSVG=ON
-- The CXX compiler identification is GNU 11.3.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Injecting headers to force assertions. This can have side-effects, USE WITH CAUTION!
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found suitable version "1.74.0", minimum required is "1.71.0") found
components: program_options unit_test_framework
CMake Warning at CMakeLists.txt:218 (message):
  Found Boost 1.74.0 - recommended is at least 1.78.0


-- Looking for C++ include filesystem
-- Looking for C++ include filesystem - found
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED
-- Performing Test CXX_FILESYSTEM_NO_LINK_NEEDED - Success
-- Building actsvg as part of the ACTS project
-- Building 'actsvg::core' component
-- Building 'actsvg::meta' component
-- Building autodiff as part of the ACTS project
-- CCache: using ccache to potentially speed up future build tasks.
-- Including DD4hepBuild.cmake
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.74.0/BoostConfig.cmake (found version "1.74.0")  
-- DD4hep uses Geant4
-- Found EXPAT: /usr/lib/x86_64-linux-gnu/libexpat.so (found suitable version "2.4.7", minimum required is "2.4.7") 
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found suitable version "1.2.11", minimum required is "1.2.11") 
-- Looking for C++ include pthread.h
-- Looking for C++ include pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE  
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found suitable version "3.2.3", minimum required is "3.2.3") 
-- Found Geant4: /usr/local/lib/cmake/Geant4/Geant4Config.cmake (found suitable version "11.1.1", minimum required is "10.2.2") 
-- Found nlohmann_json: /usr/local/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found suitable version "3.11.2", minimum required is "3.11.2")
-- Found Python: /usr/include/python3.10 (found suitable exact version "3.10.6") found components: Development Development.Module Development.Embed 
-- |++> Using python executable:  /usr/bin/python3.10
-- |++> DD4hep: Looking for Components: DDCoreDDDetectors
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found version "3.2.3") 
-- Found DD4hep: /usr/local (Required is at least version "1.21") 
-- Building nlohmann_json as part of the ACTS project
-- Using the single-header code from /builds/acts/ci-bridge/build/_deps/nlohmann_json-src/single_include/
-- Found OnnxRuntime library at /usr/local/lib/libonnxruntime.so
-- Found OnnxRuntime includes at /usr/local/include/onnxruntime/core/session (API version: 13)
-- Found OnnxRuntime: /usr/local/lib/libonnxruntime.so (Required is at least version "1.12.0") 
-- Found Python: /usr/bin/python3.10 (found version "3.10.6") found components: Interpreter 
-- Found podio: /usr/local/lib/cmake/podio/podioConfig.cmake (Required is at least version "0.6") 
-- Found podio: /usr/local/lib/cmake/podio/podioConfig.cmake  
-- Found EDM4HEP: /usr/local/lib/cmake/EDM4HEP/EDM4HEPConfig.cmake (Required is at least version "0.7") 
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found suitable version "3.2.3", minimum required is "3.2.3") 
-- Found Geant4: /usr/local/lib/cmake/Geant4/Geant4Config.cmake (found version "11.1.1") 
-- Building dfelibs as part of the ACTS project
-- Found Python: /usr/bin/python3.10 (found suitable version "3.10.6", minimum required is "3.8") found components: Interpreter Development
Development.Module Development.Embed
-- Building pybind11 as part of the ACTS project
-- pybind11 v2.10.1 
-- Performing Test HAS_FLTO
-- Performing Test HAS_FLTO - Success
-- DD4hep uses Geant4
-- Found Geant4: /usr/local/lib/cmake/Geant4/Geant4Config.cmake (found suitable version "11.1.1", minimum required is "10.2.2") 
-- Found Python: /usr/include/python3.10 (found suitable exact version "3.10.6") found components: Development Development.Module Development.Embed 
-- |++> Using python executable:  /usr/bin/python3.10
-- |++> DD4hep: Looking for Components: DDCoreDDG4DDDetectors
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found version "3.2.3") 
-- Found Pythia8: /usr/local/lib/libpythia8.so  
-- Enable component 'Core' in 'Core'
-- Enable log failure threshold
-- Enable component 'PluginAutodiff' in 'Plugins/Autodiff'
-- Enable component 'PluginActSVG' in 'Plugins/ActSVG'
-- Ignore component 'PluginCuda' in 'Plugins/Cuda'
-- Enable component 'PluginFpeMonitoring' in 'Plugins/FpeMonitoring'
-- Looking for backtrace
-- Looking for backtrace - found
-- backtrace facility detected in default set of libraries
-- Found Backtrace: /usr/include  
-- Does backtrace work with the default include
-- Does backtrace work with the default include - yes
-- Does backtrace work without linker flag
-- Does backtrace work without linker flag - no
-- Does backtrace work with linker flag
-- Does backtrace work with linker flag - yes
-- Enable component 'PluginGeant4' in 'Plugins/Geant4'
-- Enable component 'PluginIdentification' in 'Plugins/Identification'
-- Enable component 'PluginJson' in 'Plugins/Json'
-- Enable component 'PluginLegacy' in 'Plugins/Legacy'
-- Enable component 'PluginOnnx' in 'Plugins/Onnx'
-- Ignore component 'PluginMlpack' in 'Plugins/Mlpack'
-- Ignore component 'PluginSycl' in 'Plugins/Sycl'
-- Ignore component 'PluginExaTrkX' in 'Plugins/ExaTrkX'
-- Enable component 'PluginTGeo' in 'Plugins/TGeo'
-- Enable component 'PluginDD4hep' in 'Plugins/DD4hep'
-- Enable component 'PluginEDM4hep' in 'Plugins/EDM4hep'
-- Enable component 'Fatras' in 'Fatras'
-- Enable component 'FatrasGeant4' in 'Fatras/Geant4'
-- Enable component 'Alignment' in 'Alignment'
-- Enable subdirectory 'thirdparty/OpenDataDetector'
-- DD4hep uses Geant4
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found suitable version "3.2.3", minimum required is "3.2.3") 
-- |++> Using python executable:  /usr/bin/python3.10
-- |++> DD4hep: Looking for Components: DDCoreDDDetectors
-- Found XercesC: /usr/lib/x86_64-linux-gnu/libxerces-c.so (found version "3.2.3") 
-- The C compiler identification is GNU 11.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Enable subdirectory 'Examples'
-- Enable subdirectory 'Examples/Algorithms/Digitization'
-- Enable subdirectory 'Examples/Algorithms/HepMC'
-- Enable subdirectory 'Examples/Algorithms/Geant4HepMC'
-- Enable subdirectory 'Examples/Algorithms/Geant4'
-- Enable subdirectory 'Examples/Algorithms/GeneratorsPythia8'
-- Ignore subdirectory 'Examples/Algorithms/TrackFindingExaTrkX'
-- Enable subdirectory 'Examples/Algorithms/TrackFindingML'
-- Enable subdirectory 'Examples/Algorithms/Alignment'
-- Enable subdirectory 'Examples/Detectors/DD4hepDetector'
-- Enable subdirectory 'Examples/Detectors/Geant4Detector'
-- Enable subdirectory 'Examples/Detectors/MuonSpectrometerMockupDetector'
-- Enable subdirectory 'Examples/Framework/ML'
-- Enable subdirectory 'Examples/Io/EDM4hep'
-- Enable subdirectory 'Examples/Io/HepMC3'
-- Enable subdirectory 'Examples/Io/Svg'
-- Enable subdirectory 'Examples/Run'
CMake Warning at Examples/Run/CMakeLists.txt:1 (message):
  The examples binaries are deprecated and may be removed in the future.
  Consider using the python bindings.


-- Enable subdirectory 'Examples/Run/DD4hep'
-- Enable subdirectory 'Examples/Run/Digitization/DD4hep'
-- Enable subdirectory 'Examples/Run/Fatras/DD4hep'
-- Enable subdirectory 'Examples/Run/Geant4'
-- Enable subdirectory 'Examples/Run/Geant4/DD4hep'
-- Enable subdirectory 'Examples/Run/Geant4/HepMC'
-- Enable subdirectory 'Examples/Run/Generators/Pythia8'
-- Enable subdirectory 'Examples/Run/Geometry/DD4hep'
-- Enable subdirectory 'Examples/Run/HepMC3'
-- Enable subdirectory 'Examples/Run/MaterialMapping/DD4hep'
-- Enable subdirectory 'Examples/Run/MaterialMapping/TGeo'
-- Enable subdirectory 'Examples/Run/Propagation/DD4hep'
-- Enable subdirectory 'Examples/Run/Reconstruction/DD4hep'
-- Enable subdirectory 'Examples/Run/Vertexing/Pythia8'
-- Enable subdirectory 'Examples/Run/Alignment'
-- Enable subdirectory 'Examples/Python'
-- Enable subdirectory 'Examples/Scripts'
-- Enable subdirectory 'Tests/Benchmarks'
-- Enable subdirectory 'Tests/IntegrationTests'
-- Enable subdirectory 'Tests/IntegrationTests/Autodiff'
-- Enable subdirectory 'Tests/IntegrationTests/Fatras'
-- Enable subdirectory 'Tests/IntegrationTests/Legacy'
-- Enable subdirectory 'Tests/UnitTests'
-- Enable subdirectory 'Tests/UnitTests/Examples'
-- Enable subdirectory 'Tests/UnitTests/Examples/Io/Json'
-- Enable subdirectory 'Tests/UnitTests/Benchmarks'
-- Enable subdirectory 'Tests/UnitTests/Fatras'
-- Enable subdirectory 'Tests/UnitTests/Plugins/ActSVG'
-- Ignore subdirectory 'Tests/UnitTests/Plugins/Cuda'
-- Ignore subdirectory 'Tests/UnitTests/Plugins/ExaTrkX'
-- Enable subdirectory 'Tests/UnitTests/Plugins/Geant4'
-- Enable subdirectory 'Tests/UnitTests/Plugins/Json'
-- Ignore subdirectory 'Tests/UnitTests/Plugins/Sycl'
-- Enable subdirectory 'Tests/UnitTests/Plugins/TGeo'
-- Enable subdirectory 'Tests/UnitTests/Plugins/EDM4hep'
-- Enable subdirectory 'Tests/UnitTests/Plugins/FpeMonitoring'
-- Enable subdirectory 'Tests/UnitTests/Alignment'
-- Ignore subdirectory 'docs'
-- Configuring done
-- Generating done
-- Build files have been written to: /builds/acts/ci-bridge/build
$ ccache -z
Statistics zeroed
$ cmake --build build -- -j3
[1/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/PrintParameters.cpp.o
[2/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/NeutralTrackParameters.cpp.o
[3/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/TransformationBoundToFree.cpp.o
[4/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/TrackParameters.cpp.o
[5/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Surfaces/LineSurface.cpp.o
[6/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/TrackStatePropMask.cpp.o
[7/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/TransformationFreeToBound.cpp.o
[8/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/VectorTrackContainer.cpp.o
[9/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/VectorMultiTrajectory.cpp.o
[10/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/EventData/CorrectedTransformationFreeToBound.cpp.o
[11/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Digitization/DigitizationModule.cpp.o
[12/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Definitions/Common.cpp.o
[13/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Definitions/Direction.cpp.o
[14/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Definitions/ParticleData.cpp.o
[15/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Digitization/PlanarModuleStepper.cpp.o
[16/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Digitization/CartesianSegmentation.cpp.o
[17/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Detector/detail/CylindricalDetectorHelper.cpp.o
FAILED: Core/CMakeFiles/ActsCore.dir/src/Detector/detail/CylindricalDetectorHelper.cpp.o 
ccache /usr/bin/c++ -DACTS_ENABLE_LOG_FAILURE_THRESHOLD -DActsCore_EXPORTS -DBOOST_ALL_NO_LIB -I/builds/acts/ci-bridge/src/Core/include
-I/builds/acts/ci-bridge/build/Core -isystem /builds/acts/ci-bridge/src/cmake/assert_include -isystem /usr/include/eigen3 -Werror -Wall -Wextra
-Wpedantic -Wshadow -Wno-unused-local-typedefs -O2 -g -DNDEBUG  -fPIC -MD -MT
Core/CMakeFiles/ActsCore.dir/src/Detector/detail/CylindricalDetectorHelper.cpp.o -MF
Core/CMakeFiles/ActsCore.dir/src/Detector/detail/CylindricalDetectorHelper.cpp.o.d -o
Core/CMakeFiles/ActsCore.dir/src/Detector/detail/CylindricalDetectorHelper.cpp.o -c /builds/acts/ci-
bridge/src/Core/src/Detector/detail/CylindricalDetectorHelper.cpp
In file included from /builds/acts/ci-bridge/src/Core/include/Acts/Detector/DetectorComponents.hpp:14,
                 from /builds/acts/ci-bridge/src/Core/include/Acts/Detector/detail/CylindricalDetectorHelper.hpp:13,
                 from /builds/acts/ci-bridge/src/Core/src/Detector/detail/CylindricalDetectorHelper.cpp:9:
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp:181:15: error: 'void
Acts::Experimental::AdditionalSurfacesImpl::update(const GeometryContext&, Acts::Experimental::NavigationState&) const' marked 'override', but does
not override
  181 |   inline void update([[maybe_unused]] const GeometryContext& gctx,
      |               ^~~~~~
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp: In member function 'void
Acts::Experimental::AdditionalSurfacesImpl::update(const GeometryContext&, Acts::Experimental::NavigationState&) const':
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp:183:5: error: 'SurfacesFiller' has not been declared
  183 |     SurfacesFiller::fill(nState, surfaces);
      |     ^~~~~~~~~~~~~~
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp: At global scope:
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp:192:61: error: 'SurfacesFiller' was not declared in this scope
  192 |     IndexedUpdatorImpl<grid_type, IndexedSurfacesExtractor, SurfacesFiller>;
      |                                                             ^~~~~~~~~~~~~~
/builds/acts/ci-bridge/src/Core/include/Acts/Navigation/SurfaceCandidatesProviders.hpp:192:75: error: template argument 3 is invalid
  192 |     IndexedUpdatorImpl<grid_type, IndexedSurfacesExtractor, SurfacesFiller>;
      |                                                                           ^
[18/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Detector/detail/PortalHelper.cpp.o
[19/1227] Building CXX object Core/CMakeFiles/ActsCore.dir/src/Detector/detail/SupportHelper.cpp.o
ninja: build stopped: subcommand failed.
section_end:1690207517:step_script
section_start:1690207517:archive_cache_on_failure
Saving cache for failed job
Creating cache ccache-build-linux-ubuntu-newnav-typesafe-surfaceprovider-r1-1-protected...
/builds/acts/ci-bridge/ccache: found 596 matching files and directories 
Uploading cache.zip to http://acts-ci-2-alma9.cern.ch:9000/cache/project/132265/ccache-build-linux-ubuntu-newnav-typesafe-
surfaceprovider-r1-1-protected
Created cache
section_end:1690207521:archive_cache_on_failure
section_start:1690207521:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1690207522:cleanup_file_variables
ERROR: Job failed: exit code 1