-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove target volume estimation from Navigator
#3242
Merged
kodiakhq
merged 9 commits into
acts-project:main
from
andiwand:remove-navigator-target-volume-estimation
Aug 29, 2024
Merged
refactor: Remove target volume estimation from Navigator
#3242
kodiakhq
merged 9 commits into
acts-project:main
from
andiwand:remove-navigator-target-volume-estimation
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#3217) This is an attempt to remove (IMO) unnecessary complexity from the `Navigator`. We have a target volume estimation which runs a couple of times to guess the target volume based on an intersection with the target surface. IMO if we know the target surface we should also know the target volume and the user is responsible for passing this information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3242 +/- ##
==========================================
- Coverage 47.65% 47.62% -0.04%
==========================================
Files 507 507
Lines 29207 29167 -40
Branches 14012 13986 -26
==========================================
- Hits 13918 13890 -28
- Misses 5265 5272 +7
+ Partials 10024 10005 -19 ☔ View full report in Codecov by Sentry. |
…ator-target-volume-estimation
acts-project-service
added
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Aug 7, 2024
andiwand
removed
Breaks Athena build
This PR breaks the Athena build
Fails Athena tests
This PR causes a failure in the Athena tests
🚧 WIP
Work-in-progress
labels
Aug 28, 2024
acts-project-service
added
the
Fails Athena tests
This PR causes a failure in the Athena tests
label
Aug 28, 2024
AJPfleger
approved these changes
Aug 29, 2024
andiwand
added
automerge
and removed
Fails Athena tests
This PR causes a failure in the Athena tests
labels
Aug 29, 2024
Quality Gate passedIssues Measures |
acts-project-service
added
the
Breaks Athena build
This PR breaks the Athena build
label
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3217 after it was reverted with #3241. There were a couple of failures monitored in Athena which could not be fixed right away.
This is an attempt to remove (IMO) unnecessary complexity from the Navigator. We have a target volume estimation which runs a couple of times to guess the target volume based on an intersection with the target surface. IMO if we know the target surface we should also know the target volume and the user is responsible for passing this information.