Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add C++20 track parameter, navigator, and stepper concepts #3492

Conversation

stephenswat
Copy link
Member

This concept replaces the previously existing concepts for navigators and steppers with C++20 concepts.

@github-actions github-actions bot added the Component - Core Affects the Core module label Aug 7, 2024
@stephenswat stephenswat force-pushed the refactor/stepper_navigator_cxx20_concept branch 2 times, most recently from eddd948 to 6d02075 Compare August 7, 2024 11:53
@paulgessinger paulgessinger added this to the v36.1.0 milestone Aug 7, 2024
paulgessinger
paulgessinger previously approved these changes Aug 7, 2024
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, no substantial comments.

Core/include/Acts/Propagator/StepperConcept.hpp Outdated Show resolved Hide resolved
Core/include/Acts/Propagator/StepperConcept.hpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Aug 7, 2024

📊: Physics performance monitoring for 9531a1a

Full contents

physmon summary

@paulgessinger paulgessinger modified the milestones: v36.1.0, next Aug 19, 2024
@andiwand
Copy link
Contributor

How do we proceed here @paulgessinger @stephenswat ?

@paulgessinger
Copy link
Member

We can proceed with this when @stephenswat is back to work I suppose.

@stephenswat
Copy link
Member Author

I'll update this today!

@stephenswat stephenswat changed the title refactor: Add C++20 navigator and stepper concepts refactor: Add C++20 track parameter, navigator, and stepper concepts Aug 23, 2024
@stephenswat
Copy link
Member Author

I folded #3485 into this.

@stephenswat
Copy link
Member Author

This now depends on #3484.

This concept replaces the previously existing concepts for track
parameters, navigators, and steppers with C++20 concepts.
@github-actions github-actions bot removed Component - Examples Affects the Examples module Track Fitting labels Aug 26, 2024
@stephenswat stephenswat marked this pull request as ready for review August 26, 2024 08:30
@stephenswat
Copy link
Member Author

This is now ready for review.

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Core/include/Acts/Utilities/Concepts.hpp Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 27, 2024

@kodiakhq kodiakhq bot merged commit eb5d0d4 into acts-project:main Aug 27, 2024
42 checks passed
kodiakhq bot pushed a commit that referenced this pull request Aug 29, 2024
This PR removes the remaining use of the detection idiom, as well as the code to support it. It has served us well, but can not be replaced by C++20 concepts.

Depends on #3492.
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants