-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add C++20 track parameter, navigator, and stepper concepts #3492
refactor: Add C++20 track parameter, navigator, and stepper concepts #3492
Conversation
eddd948
to
6d02075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it, no substantial comments.
How do we proceed here @paulgessinger @stephenswat ? |
We can proceed with this when @stephenswat is back to work I suppose. |
I'll update this today! |
I folded #3485 into this. |
This now depends on #3484. |
6d02075
to
6bc7420
Compare
6bc7420
to
117e606
Compare
This concept replaces the previously existing concepts for track parameters, navigators, and steppers with C++20 concepts.
This is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Quality Gate passedIssues Measures |
This PR removes the remaining use of the detection idiom, as well as the code to support it. It has served us well, but can not be replaced by C++20 concepts. Depends on #3492.
This concept replaces the previously existing concepts for navigators and steppers with C++20 concepts.