Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GeoModel plugin changes for ITk building. #3519

Conversation

benjaminhuth
Copy link
Member

This adds some funcitonality to the GeoModelPlugin:

  • A very simple Module splitter based on the annulus bound radii
  • A subclass of GeoModelDetectorElement that holds ITk specific information
  • Bindings to python

@benjaminhuth benjaminhuth added this to the next milestone Aug 20, 2024
@github-actions github-actions bot added Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

📊: Physics performance monitoring for 1764173

Full contents

physmon summary

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The database name is separate from the volume name?

andiwand
andiwand previously approved these changes Aug 29, 2024
andiwand
andiwand previously approved these changes Aug 29, 2024
@andiwand
Copy link
Contributor

blocked by clang-tidy failures

AJPfleger
AJPfleger previously approved these changes Aug 29, 2024
@benjaminhuth
Copy link
Member Author

I'd like to hold this for a moment, I'm currently working with that change and maybe there are some little adjustements that are needed still...

Copy link

sonarcloud bot commented Aug 30, 2024

Benjamin Huth added 2 commits September 2, 2024 16:33
@benjaminhuth benjaminhuth marked this pull request as draft September 3, 2024 07:19
@github-actions github-actions bot added the Stale label Oct 3, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants