Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make RootTrackStatesWriter FPE safe #3559

Merged

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Aug 27, 2024

  • Explicitly protect against FPEs originating from std::sqrt(-1)
    • Explicitly writing nan for these cases
  • Explicit float conversions for writing
  • Usage of Acts::BoundVector for bound quantities

Fixes

@andiwand andiwand added this to the next milestone Aug 27, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Aug 27, 2024
Copy link

github-actions bot commented Aug 27, 2024

📊: Physics performance monitoring for 0121c45

Full contents

physmon summary

AJPfleger
AJPfleger previously approved these changes Aug 27, 2024
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this FPE was bugging me a lot during the last weeks.

AJPfleger
AJPfleger previously approved these changes Aug 27, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

@kodiakhq kodiakhq bot merged commit b46a6f6 into acts-project:main Aug 28, 2024
42 checks passed
@andiwand andiwand deleted the fix-make-roottrackstateswriter-fpe-safe branch August 28, 2024 08:00
@andiwand andiwand modified the milestones: next, v36.3.0 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants