Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Further fixes to detray plugin #3563

Closed
wants to merge 2 commits into from
Closed

fix: Further fixes to detray plugin #3563

wants to merge 2 commits into from

Conversation

stephenswat
Copy link
Member

This commit makes several minor changes to the detray plugin:

  1. It fixes a bug in the detray conversion code.
  2. It adds the detray plugin to the downstream project.
  3. It disables the build of the detray CUDA code, which we don't need.

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Aug 27, 2024
@asalzburger asalzburger mentioned this pull request Aug 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 27, 2024 •
edited
Loading

📊: Physics performance monitoring for 1cc3df3

Full contents

physmon summary

@asalzburger
Copy link
Contributor

@stephenswat - some of this is now obsolete, I guess, can you have a look, please?

@stephenswat
Copy link
Member Author

stephenswat commented Aug 29, 2024 •
edited
Loading

@asalzburger updated; this is now very trivial.

EDIT: Let me make the .cpp change.

@github-actions github-actions bot removed the Component - Plugins Affects one or more Plugins label Aug 29, 2024
@stephenswat
Copy link
Member Author

@asalzburger could you take a look?

@stephenswat
fix: Further fixes to detray plugin
541712c 
This commit makes several minor changes to the detray plugin:

1. It adds the detray plugin to the downstream project.
2. It disables the build of the detray CUDA code, which we don't need.
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Aug 29, 2024
@andiwand andiwand added this to the next milestone Aug 30, 2024
@stephenswat
Copy link
Member Author

stephenswat commented Aug 30, 2024 •
edited
Loading

Closes #3363.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 25%)
0.0% Line Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@andiwand
Copy link
Contributor

can you force merge this one @asalzburger ?

@andiwand
Copy link
Contributor

andiwand commented Sep 7, 2024

@stephenswat can you resolve the conflict?

@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@asalzburger asalzburger asalzburger left review comments

@andiwand andiwand andiwand approved these changes

Assignees
No one assigned
Labels
Component - Plugins Affects one or more Plugins
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenswat @asalzburger @andiwand @paulgessinger