refactor!: Fuse Actor and Aborter
#3573
Conversation
github-actions
bot
added
Component - Core
|
Yes, why not - we actually had The only comment I have here is that the ordering of the actors gets even more important, but that's not a bad thing - on the contrary, I would say. |
|
The way I combined them right now preserves the ordering of the actor/aborter. I just combined the Potentially we could also fuse the two functions since it is really just the return value which is different but then we have to be more careful about the ordering like you said @asalzburger |
Core/include/Acts/Propagator/detail/actor_list_implementation.hpp
Outdated
Show resolved
Hide resolved
acts-policybot
bot
dismissed
stephenswat’s stale review
Invalidated by push of 09941f0
|
@stephenswat I was wondering if the |
|
I left the flags out and applied your comments @stephenswat. I think that makes it way easier to just check for methods and not combinations |
acts-policybot
bot
dismissed
stephenswat’s stale review
Invalidated by push of dadfbfe
This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages. Depends on acts-project#3573.
|
This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages. Depends on acts-project#3573.
This commit removes the mostly unused MPL library. The few cases in which it was being used could be easily refactored into uses of fold expressions, which should allow better error messages. Depends on acts-project#3573.
Fuses Actors and Aborters into a single object with seperate
actandcheckcalls. The motivation for this is that Aborters cannot hold any state by their own currently but need an Actor to point to. To simplify this I propose to couple these two concepts.At the same time I reworked the call mechanism for the actor and aborter functions which concepts and a simpler dispatch mechanism.
Class names changed a bit from
ActionListtoActorListfor example.