Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding GeomentryId to detray portals #3606

Conversation

asalzburger
Copy link
Contributor

The geometry ID was not correctly added to the detray portals, this mini-PR fixes this.

@asalzburger asalzburger added this to the next milestone Sep 11, 2024
@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Sep 11, 2024
Copy link

📊: Physics performance monitoring for 9b1cbd7

Full contents

physmon summary

Copy link

sonarcloud bot commented Sep 11, 2024

@asalzburger asalzburger merged commit 3fb892e into acts-project:main Sep 11, 2024
43 checks passed
@asalzburger asalzburger deleted the fix-add-forgotten-geoid-detray-portals branch September 11, 2024 19:29
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [3fb892e]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 11, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Plugins Affects one or more Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants