Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update traccc to v0.16.0 #3634

Merged
merged 4 commits into from
Sep 23, 2024
Merged

build: Update traccc to v0.16.0 #3634

merged 4 commits into from
Sep 23, 2024

Conversation

stephenswat
Copy link
Member

This commit updates traccc to version 0.16.0 and, with it, detray to v0.75.2.

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Sep 20, 2024
@stephenswat
Copy link
Member Author

@asalzburger

@asalzburger
Copy link
Contributor

@stephenswat the version synchronisation went in, so this can be updated now.

@stephenswat
Copy link
Member Author

@asalzburger updated.

@asalzburger
Copy link
Contributor

#include <detray/test/utils/inspectors.hpp>

has now moved to test_utils - right @niermann999 ?

@niermann999
Copy link
Contributor

#include <detray/test/utils/inspectors.hpp>

has now moved to test_utils - right @niermann999 ?

yes, correct

@stephenswat stephenswat force-pushed the build/traccc_0.16.0 branch 3 times, most recently from cad879d to 78719ba Compare September 20, 2024 15:23
niermann999
niermann999 previously approved these changes Sep 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

📊: Physics performance monitoring for 96c651e

Full contents

physmon summary

@asalzburger asalzburger added this to the next milestone Sep 23, 2024
@asalzburger
Copy link
Contributor

I still saw a weird build error associated with actsvg::core in the clang-tidy build. Rebased, and let's see.

@stephenswat
Copy link
Member Author

I will look into this after the morning meeting.

@stephenswat
build: Update traccc to v0.16.0
026f7d0 
This commit updates traccc to version 0.16.0 and, with it, detray to
v0.75.2.
stephenswat added a commit to stephenswat/acts that referenced this pull request Sep 23, 2024
@stephenswat
ci: Run clang-tidy on the ActSVG plugin
44380b8 
In acts-project#3634, I am struggling with clang-tidy errors which popped up after I
had to transiently enable the ActSVG plugin. In order to solve this
problem is propose we unconditionally enable clang-tidy on ActSVG. This
PR does that, and it also fixes any existing clang-tidy issues.
@stephenswat stephenswat mentioned this pull request Sep 23, 2024
Merged
@stephenswat
Copy link
Member Author

Found the clang-tidy error, fixed in #3639.

@asalzburger
Copy link
Contributor

Waiting for #3639 to be merged in.

paulgessinger pushed a commit that referenced this pull request Sep 23, 2024
@stephenswat
ci: Run clang-tidy on the ActSVG plugin (#3639)
59250ad 
In #3634, I am struggling with clang-tidy errors which popped up after I
had to transiently enable the ActSVG plugin. In order to solve this
problem is propose we unconditionally enable clang-tidy on ActSVG. This
PR does that, and it also fixes any existing clang-tidy issues.
@asalzburger asalzburger self-requested a review September 23, 2024 19:58
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kodiakhq kodiakhq bot merged commit f404ca2 into acts-project:main Sep 23, 2024
44 checks passed
@acts-project-service
Copy link
Collaborator

acts-project-service commented Sep 23, 2024 •
edited
Loading

✅ Athena integration test results [f404ca2]

✅ All tests successful

status job report
🟢 report_pull_request
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco
🟢 test_ActsDumpGeometryIdentifiers
🟢 test_ActsCheckObjectCountsCachedWorkflow
🟢 test_ActsCheckObjectCountsWorkflow
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_unit_tests

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Sep 23, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

@niermann999 niermann999 niermann999 left review comments

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
v37.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@stephenswat @asalzburger @niermann999 @acts-project-service @paulgessinger @AJPfleger