refactor!: converge to naming sourceLink
#3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component - Core
andiwand
approved these changes
Sep 25, 2024
AJPfleger
changed the title
sourceLinksourceLink
|
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
We want to add the `HoleFlag`, when `(precedingMeasurementExists && surfaceIsSensitive)`. We had the case, that we would wrongly always tag holes, when `surfaceIsSensitive && surfaceHasMaterial` because then the check for `precedingMeasurementExists` would have been short-circuited. The physmon does no change, because there we use the ODD which has material and sensitive on different surface, therefore could not be short-circuited. That's why we only see a difference in the generic detector hashes. blocked: - #3647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.