Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant operator!=, introduce operator<=> #3660

Merged
merged 7 commits into from
Sep 29, 2024

Conversation

AJPfleger
Copy link
Contributor

  • Removed unnecessary operator!= implementations and relied on C++20's automatic generation of operator!= from operator==.
  • Introduced the spaceship operator 🚀 <=> where applicable/necessary.
  • Simplified the code by leveraging modern C++20 features, reducing redundancy and improving maintainability.

@AJPfleger AJPfleger added this to the v37.0.0 milestone Sep 27, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Fatras Affects the Fatras module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Event Data Model Vertexing Seeding Track Finding labels Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

📊: Physics performance monitoring for 78ad6ec

Full contents

physmon summary

Copy link

sonarcloud bot commented Sep 28, 2024

@kodiakhq kodiakhq bot merged commit 019a5fe into acts-project:main Sep 29, 2024
44 checks passed
@AJPfleger AJPfleger deleted the inequality branch September 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Fatras Affects the Fatras module Component - Plugins Affects one or more Plugins Event Data Model Seeding Track Finding Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants