Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding possibility to read flat surface container #3668

Merged

Conversation

asalzburger
Copy link
Contributor

@asalzburger asalzburger commented Sep 30, 2024

This PR adds a function to the JsonSurfacesReader that allows to read in a flat container rather than a Hierarchy map:

>>> import acts
>>> from acts import examples
>>> sOptions = acts.examples.SurfaceJsonOptions()
>>> sOptions.inputFile = "some_sensitive_mod.json"
>>> sOptions.jsonEntryPath = ["surfaces"]
>>> surfaces = acts.examples.rreadSurfaceVectorFromJson(sOptions)
>>> print(len(surfaces))
16668
>>> geoContext = acts.GeometryContext()
>>> viewConfig = acts.ViewConfig()
>>> acts.examples.writeSurfacesObj(surfaces, geoContext, viewConfig, "some-surfaces.obj")

will work with this out of the box.

@asalzburger asalzburger added this to the next milestone Sep 30, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Sep 30, 2024
Copy link

github-actions bot commented Sep 30, 2024

📊: Physics performance monitoring for 66386fb

Full contents

physmon summary

asalzburger and others added 2 commits September 30, 2024 21:34
…er.hpp

Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
@kodiakhq kodiakhq bot merged commit 32f67b3 into acts-project:main Sep 30, 2024
41 checks passed
Copy link

sonarcloud bot commented Oct 1, 2024

@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 1, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.0.0 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants