Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(geo): Teach ProtoLayer to respect local coordinate system #3697

Merged

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Oct 7, 2024

Needed for #3502


This pull request introduces several enhancements and new features to the ProtoLayer struct and its associated tests in the Core and Tests directories. The key changes include the addition of a local transform, multiple constructors, and new test cases to validate the functionality.

Enhancements to ProtoLayer struct:

  • Added a new member transform to the ProtoLayer struct and updated its constructors to accept a Transform3 parameter with a default value of Transform3::Identity(). (Core/include/Acts/Geometry/ProtoLayer.hpp, Core/src/Geometry/ProtoLayer.cpp) [1] [2] [3] [4] [5]
  • Implemented a friend function for the output stream operator to facilitate easy printing of ProtoLayer objects. (Core/include/Acts/Geometry/ProtoLayer.hpp)

Codebase simplification:

  • Removed unused #include directives from ProtoLayer.cpp to clean up the code. (Core/src/Geometry/ProtoLayer.cpp)

Enhancements to unit tests:

  • Added new test cases in ProtoLayerTests.cpp to validate the behavior of ProtoLayer with different transformations.

These changes enhance the flexibility and functionality of the ProtoLayer struct and ensure that the new features are thoroughly tested.

@paulgessinger paulgessinger added this to the next milestone Oct 7, 2024
@paulgessinger paulgessinger mentioned this pull request Oct 7, 2024
@github-actions github-actions bot added the Component - Core Affects the Core module label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

📊: Physics performance monitoring for 33ef88b

Full contents

physmon summary

Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes a lot of sense, indeed.

Copy link

sonarcloud bot commented Oct 7, 2024

@kodiakhq kodiakhq bot merged commit 39c6aca into acts-project:main Oct 7, 2024
44 checks passed
@github-actions github-actions bot removed the automerge label Oct 7, 2024
@acts-project-service
Copy link
Collaborator

🔴 Athena integration test results [39c6aca]

Build job with this PR failed!

Please investigate the build job for the pipeline!

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Oct 7, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants