Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Do not insert space points if not inside grid boundaries #3698

Merged
merged 13 commits into from
Oct 9, 2024

Conversation

CarloVarni
Copy link
Collaborator

@CarloVarni CarloVarni commented Oct 7, 2024

Changes:

  • Calling grid.isInside to check if space point falls within the boundaries
  • Check min and max values are correct (i.e. min < max)
  • Additional changes to check phi is within [-std::numbers::pi, std::numbers::pi]
  • Move config and options values to double (also because units are doubles). Only partial since moving them all requires change in other parts of the code (will follow up in another PR)
  • Use std::numbers::pi instead of M_PI

In the example, we go back to the previous computation for the rMiddleSPRange. Not clear why the std::floor was introduced in the first place, going back to that computation while we figure out why

@CarloVarni CarloVarni added this to the next milestone Oct 7, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding Track Finding labels Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

📊: Physics performance monitoring for 9a3e5b5

Full contents

physmon summary

Copy link

sonarcloud bot commented Oct 9, 2024

@kodiakhq kodiakhq bot merged commit 5ec1437 into acts-project:main Oct 9, 2024
42 checks passed
@github-actions github-actions bot removed the automerge label Oct 9, 2024
@CarloVarni CarloVarni deleted the DoNotConsiderOverUnder branch October 9, 2024 12:39
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Seeding Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants