perf: Avoid allocations in TrapezoidBounds::inside

[andiwand]

Looking at some flame graphs I spotted some allocations in TrapezoidBounds::inside which should not be necessary. It does not look like it had a big impact.

Apart from that I decided to replace the generic template argument for insidePolygon with a span.

---

This pull request includes several changes to the Acts library, focusing on improving the handling of vertex data by using std::span and enhancing the boundary check logic. The most important changes include the introduction of std::span for vertex containers, the addition of necessary includes, and the modification of boundary check methods to use std::span.

Improvements to vertex handling:

• Core/include/Acts/Surfaces/detail/BoundaryCheckHelper.hpp: Changed the insidePolygon function to use std::span<const Vector2> for vertex containers.
• Core/include/Acts/Surfaces/detail/VerticesHelper.hpp: Modified the computeClosestPointOnPolygon function to use std::span<const Vector2> for vertex containers.

Inclusion of necessary headers:

• Core/include/Acts/Surfaces/detail/BoundaryCheckHelper.hpp: Added the #include <span> directive.
• Core/include/Acts/Surfaces/detail/VerticesHelper.hpp: Added the #include <span> directive.
• Core/src/Surfaces/DiamondBounds.cpp: Added the #include "Acts/Definitions/Algebra.hpp" directive.

Boundary check logic enhancements:

• Core/src/Surfaces/DiamondBounds.cpp: Updated the inside method to use an array of Vector2 for vertices and the insidePolygon function.
• Core/src/Surfaces/TrapezoidBounds.cpp: Changed the vertices container from std::vector to an array of Vector2 in the inside method.

[github-actions]

📊: Physics performance monitoring for 68a6fed

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ CKF | trackfinding | single muon | truth smeared seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF | trackfinding | single muon | truth estimated seeding
• ✅ Track Summary CKF | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF | trackfinding | single muon | default seeding
• ✅ Track Summary CKF | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF | trackfinding | single muon | orthogonal seeding
• ✅ Track Summary CKF | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Track Summary CKF | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Track Summary CKF | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[asalzburger]

Cool trick.

[asalzburger]

I think gcc now swallows that, do you want to un-draft it?

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
67.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[acts-project-service]

🔴 Athena integration test results [09ed7f3]

🔴 Some tests have failed!

Please investigate the pipeline!

status	job	report
🟢	report_pull_request
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco
🟢	run_workflow_tests_run4_mc
🔴	run_workflow_tests_run2_mc
🔴	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🔴	run_workflow_tests_run3_data
🔴	test_ActsDumpGeometryIdentifiers
🟢	test_ActsCheckObjectCountsCachedWorkflow
🟢	test_ActsCheckObjectCountsWorkflow
🟢	test_ActsEFTrackFit
🟢	test_ActsPersistifySeeds
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsAnalogueClustering
🟢	test_ActsWorkflowHeavyIons
🟢	test_ActsWorkflowFastTracking
🟢	test_ActsWorkflowCached
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🔴	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🔴	test_ActsITkTest
🟢	run_unit_tests