Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make charge smearing optional in digi config #3710

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: Make charge smearing optional in digi config #3710

merged 2 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. fix: Make charge smearing optional in digi config 

    Currently, the JSON reading for digitization configurations
unconditionally reads the charge smearing data, but this need not
necessarily be present; the geometric config for the ODD, for example,
does not have this data. As a result, parser was failing to parse the
geometric ODD digitization config. This commit makes the reading
conditional and adds tests to ensure the ODD config reading remains
functional.
    @stephenswat
    stephenswat committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    55c89fa View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/ditigitzation_optional_smearing

    @kodiakhq
    kodiakhq[bot] authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    a447fae View commit details
    Browse the repository at this point in the history