Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: z and r axis in grid for seeding are Open instead of Bound #3712

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

CarloVarni
Copy link
Collaborator

Not clear why these were Bound instead of Open.

According to documentation (i.e. https://github.com/acts-project/acts/blob/main/Core/include/Acts/Utilities/AxisFwd.hpp)

enum class AxisBoundaryType {
  /// Default behaviour: out of bounds
  /// positions are filled into the over or underflow bins
  Open,
  /// Out-of-bounds positions resolve to first/last bin
  /// respectively
  Bound,
  /// Out-of-bounds positions resolve to the outermost
  /// bin on the opposite side
  Closed,
};

For the grid case, Open seems the proper option

@github-actions github-actions bot added Component - Core Affects the Core module Seeding labels Oct 10, 2024
@CarloVarni CarloVarni added this to the next milestone Oct 10, 2024
Copy link

github-actions bot commented Oct 10, 2024

📊: Physics performance monitoring for ea85dda

Full contents

physmon summary

Copy link

sonarcloud bot commented Oct 11, 2024

@kodiakhq kodiakhq bot merged commit 2b9d1ef into acts-project:main Oct 11, 2024
42 checks passed
@CarloVarni CarloVarni deleted the OpenAxis branch October 11, 2024 16:03
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 11, 2024
@paulgessinger paulgessinger modified the milestones: next, v37.1.0 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Fails Athena tests This PR causes a failure in the Athena tests Seeding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants