-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename TrackFinderPerformanceWriter
in Examples
#3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples/Io/Performance/ActsExamples/Io/Performance/TrackFinderNTupleWriter.cpp
Outdated
Show resolved
Hide resolved
github-actions
bot
added
Infrastructure
Changes to build tools, continous integration, ...
Component - Documentation
Affects the documentation
labels
Oct 16, 2024
AJPfleger
reviewed
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think git would be happier if we do first a PR with
- Rename TrackFinderPerformanceWriter to TrackFinderNTupleWriter
and then a second one with - Rename CKFPerformanceWriter to TrackFinderPerformanceWriter
Could you maybe split this up, that we have a better track which files moved?
andiwand
force-pushed
the
ex-rename-perf-writers
branch
from
October 19, 2024 09:59
c1598cc
to
ba060ce
Compare
github-actions
bot
removed
Infrastructure
Changes to build tools, continous integration, ...
Component - Documentation
Affects the documentation
Changes Performance
labels
Oct 19, 2024
andiwand
changed the title
refactor: Rename track finder performance writers in Examples
refactor: Rename Oct 19, 2024
TrackFinderPerformanceWriter
in Examples
Quality Gate passedIssues Measures |
AJPfleger
approved these changes
Oct 19, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 19, 2024
Followup of #3737 I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the `CKFPerformanceWriter` is generic enough to write the performance for any finder. Therefore I propose to - Rename `TrackFinderPerformanceWriter` to `TrackFinderNTupleWriter` (#3737) - Rename `CKFPerformanceWriter` to `TrackFinderPerformanceWriter` (this pr) blocked by - #3742 - #3737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the
CKFPerformanceWriter
is generic enough to write the performance for any finder.Therefore I propose to
TrackFinderPerformanceWriter
toTrackFinderNTupleWriter
(this pr)CKFPerformanceWriter
toTrackFinderPerformanceWriter
blocked by