Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename TrackFinderPerformanceWriter in Examples #3737

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Oct 16, 2024

I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the CKFPerformanceWriter is generic enough to write the performance for any finder.

Therefore I propose to

  • Rename TrackFinderPerformanceWriter to TrackFinderNTupleWriter (this pr)
  • (and later) Rename CKFPerformanceWriter to TrackFinderPerformanceWriter

blocked by

@andiwand andiwand added this to the next milestone Oct 16, 2024
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

📊: Physics performance monitoring for 2b5d46b

Full contents

physmon summary

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Component - Documentation Affects the documentation labels Oct 16, 2024
@andiwand andiwand added the 🛑 blocked This item is blocked by another item label Oct 16, 2024
@andiwand andiwand marked this pull request as ready for review October 19, 2024 08:37
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think git would be happier if we do first a PR with

  • Rename TrackFinderPerformanceWriter to TrackFinderNTupleWriter
    and then a second one with
  • Rename CKFPerformanceWriter to TrackFinderPerformanceWriter

Could you maybe split this up, that we have a better track which files moved?

@github-actions github-actions bot removed Infrastructure Changes to build tools, continous integration, ... Component - Documentation Affects the documentation Changes Performance labels Oct 19, 2024
@andiwand andiwand changed the title refactor: Rename track finder performance writers in Examples refactor: Rename TrackFinderPerformanceWriter in Examples Oct 19, 2024
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2024
…3745)

Similar to #3737. I think performance writer should provide plots we can look at while the `VertexPerformanceWriter` is actually only writing NTuples.
Copy link

sonarcloud bot commented Oct 19, 2024

@andiwand andiwand removed the 🛑 blocked This item is blocked by another item label Oct 19, 2024
@kodiakhq kodiakhq bot merged commit 0627ea9 into acts-project:main Oct 19, 2024
45 checks passed
@andiwand andiwand deleted the ex-rename-perf-writers branch October 19, 2024 15:25
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2024
Followup of #3737

I usually expect some accumulated plots in the performance writers we can directly look at. At the same time the `CKFPerformanceWriter` is generic enough to write the performance for any finder.

Therefore I propose to
- Rename `TrackFinderPerformanceWriter` to `TrackFinderNTupleWriter` (#3737)
- Rename `CKFPerformanceWriter` to `TrackFinderPerformanceWriter` (this pr)

blocked by 
- #3742
- #3737
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants