Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle Fatras immediate abort edge case #3744

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

andiwand
Copy link
Contributor

Currently Fatras might abort before reaching the pointer where we initialize the particle. This leads to desynchronization between initial and final particles which will then lead to warning/error logs downstream

ParticleSele   WARNING   No final particle found for 4|11|169|0|0

The initial call of the actor is now caught be checking the propagation stage which then initializes the result object gracefully.

Discovered in #3742

@andiwand andiwand added this to the next milestone Oct 16, 2024
@github-actions github-actions bot added the Component - Fatras Affects the Fatras module label Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

📊: Physics performance monitoring for 3e436af

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review October 16, 2024 23:10
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better to not rely on something beeing NaN but on the propagation state.

Copy link

sonarcloud bot commented Oct 17, 2024

@kodiakhq kodiakhq bot merged commit c862d2d into acts-project:main Oct 17, 2024
43 checks passed
@andiwand andiwand deleted the fix-fatras-actor-edge-case branch October 18, 2024 07:05
kodiakhq bot pushed a commit that referenced this pull request Oct 18, 2024
- remove `TruthSeedRanges` as this a duplication of `ParticleSelector `
- enhance `ParticleSelector` by also input/output final particle selections which are necessary to access the number of hits
- raise some pT cuts to the usual 1 GeV
- handle downstream changes

blocked by
- #3744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Fatras Affects the Fatras module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants