Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate track parameters #3756

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

andiwand
Copy link
Contributor

Adds two free functions which allow checking BoundVectors and FreeVectorss for valid track parameters. This is then used as asserts in the track parameter EDM.

@andiwand andiwand added this to the next milestone Oct 17, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Event Data Model labels Oct 17, 2024
@andiwand
Copy link
Contributor Author

0a02484 contains your feedback @paulgessinger

@github-actions github-actions bot added the Component - Plugins Affects one or more Plugins label Oct 19, 2024
@andiwand
Copy link
Contributor Author

This fires basically everywhere. It would take quite some time to fix every single problem. I think we can just add the functionality and not assert on it for now. The question is if we really want to assert on it. $\phi $ being out of range usually does not hurt. With $\theta$ it gets trickier.

Copy link

github-actions bot commented Oct 21, 2024

📊: Physics performance monitoring for 8f0b42b

Full contents

physmon summary

@andiwand andiwand marked this pull request as ready for review October 22, 2024 09:16
Copy link

sonarcloud bot commented Oct 22, 2024

@andiwand andiwand marked this pull request as draft October 23, 2024 08:38
@andiwand
Copy link
Contributor Author

This is a bit frustrating: we have a bunch of invalid track parameters in the code which are generated randomly in different ways. I think it would be good to have one mechanism of generating random track parameters which has to be parameterized before we can continue with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants