Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java/*] Updated Java links & fixed formatting #5120

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

ThunderE75
Copy link

@ThunderE75 ThunderE75 commented Sep 13, 2024

  • I solemnly swear that this is all original content of which I am the original author
  • Pull request title is prepended with [language/lang-code] (example [python/fr-fr] or [java/en])
  • Pull request touches only one file (or a set of logically related files with similar changes made)
  • Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)
  • If you've changed any part of the YAML Frontmatter, make sure it is formatted according to CONTRIBUTING.md
    • Yes, I have double-checked quotes and field names!

@ThunderE75 ThunderE75 changed the title [java-en] Update Book Links [java/en] Update Book Links Sep 13, 2024
@ThunderE75
Copy link
Author

I had a question regarding updating links on the translated pages,

  1. In the de-de variant of this file, it already has the same outdated book links, but the books are in English, is this okay to have book resources of other language ?
  2. & in the case of the es-es variant of this file, it doesn't have links to those book resources, should we add English book links as resources, or leave it as is ?

Another doubt i have is, Should i open a PR for each translated file separately, or is it okay to have 'similar' updates of different translation under the same PR ? I have read the Contributing guidelines, but it's a confusing for me, so i am just confirming, before adding more commits to this PR.

@verhovsky
Copy link
Collaborator

verhovsky commented Sep 17, 2024

is this okay to have book resources of other language

yes, why wouldn't it be?

es-es variant of this file, it doesn't have links to those book resources, should we add English book links as resources, or leave it as is

whatever you want

Should i open a PR for each translated file separately

why would you want to write the same commit message 13 times?

I have read the Contributing guidelines

just use your judgement, it's not that serious.

@ThunderE75
Copy link
Author

  • Fixed Formatting to match the main en version
  • Added Missing resource links
  • Though, i am not native/flute in most of these language, but i believe that i have translated & checked my commits multiple times to insure that there are no grammatical mistakes
  • I have also not added additional English books to those pages that didn't have them previously, but i have updated the links on the pages that had them already.

@ThunderE75 ThunderE75 changed the title [java/en] Update Book Links [java/*] Updated Java links & fixed formatting Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants