Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unicode support for terminal #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robintw
Copy link

@robintw robintw commented Apr 28, 2020

This PR adds support for decoding unicode characters in the response that is sent for the terminal to display. This means that special characters (including weird characters for making boxes and progress bars and so on) will display properly on the terminal.

(I originally found this issue when running a script that uses tqdm and found that notebook_xterm didn't render its progress bars correctly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant