Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add php-cs fixer to bundle. #71

Merged
merged 11 commits into from
Dec 29, 2021
Merged

Add php-cs fixer to bundle. #71

merged 11 commits into from
Dec 29, 2021

Conversation

mario-fehr
Copy link
Contributor

Closes #23

@mario-fehr mario-fehr mentioned this pull request Dec 28, 2021
Open
adrenalinkin
adrenalinkin requested changes Dec 28, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.php-cs-fixer.dist.php Outdated Show resolved Hide resolved
Collection/SchemaDefinitionCollection.php Outdated Show resolved Hide resolved
@adrenalinkin
Copy link
Owner

@mfehr94 Thanks for this PR. Also add please into both workflows - that's should enable CI for you PR

on: [push, pull_request]

@mario-fehr
Copy link
Contributor Author

@adrenalinkin should the lint be with a specific php version like 7.4 or every version like UnitTests?

@adrenalinkin
Copy link
Owner

@mfehr94 single PHP version is enough

adrenalinkin
adrenalinkin requested changes Dec 29, 2021
View reviewed changes
Configuration/SwaggerCachedConfiguration.php Outdated Show resolved Hide resolved
Loader/SwaggerPhpConfigurationLoader.php Outdated Show resolved Hide resolved
@mario-fehr
Copy link
Contributor Author

@adrenalinkin added all requeted changes, all piplines are green.

adrenalinkin
adrenalinkin approved these changes Dec 29, 2021
View reviewed changes
Copy link
Owner

@adrenalinkin adrenalinkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfehr94 Good job! Thanks for help

@adrenalinkin adrenalinkin merged commit 1e41e0f into adrenalinkin:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrenalinkin adrenalinkin adrenalinkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply Symfony code style by adding php-cs-fixer
2 participants
@mario-fehr @adrenalinkin