Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: accept tf.data.Dataset inputs #166

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

adriangb
Copy link
Owner

Partially addresses #160 by enabling direct tf.data.Dataset inputs.

This mainly enables the use case where a user has an existing Dataset and Model and would like to use GridSearch or something on it, but most of the rest of the SciKeras and Sklearn features will be unavailable including:

  • Encoding/decoding of labels to allow strings, obj, etc.
  • Ability to dynamically adapt Model inputs/outputs to data

And this requires using BaseWrapper directly, or alternatively subclassing KerasClassifier or KerasRegressor to disable the transformers.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #166 (79620cd) into master (f4a9fef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           6        6           
  Lines         672      679    +7     
=======================================
+ Hits          669      676    +7     
  Misses          3        3           
Impacted Files Coverage Δ
scikeras/wrappers.py 99.45% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a9fef...79620cd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 29, 2021

📝 Docs preview for commit 79620cd at: https://www.adriangb.com/scikeras/refs/pull/166/merge/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants