Implement batch_size=-1

[adriangb]

No description provided.

[github-actions]

📝 Docs preview for commit 2c65c50 at: https://www.adriangb.com/scikeras/refs/pull/194/merge/

[codecov-io]

Codecov Report

Merging #194 (2c65c50) into master (d83bffa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   99.70%   99.71%           
=======================================
  Files           6        6           
  Lines         679      693   +14     
=======================================
+ Hits          677      691   +14     
  Misses          2        2           

Impacted Files	Coverage Δ
scikeras/wrappers.py	99.45% <100.00%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83bffa...2c65c50. Read the comment docs.

[stsievert]

I'm still a fan of keeping **kwargs in model.fit as expressed in #159 (comment). This PR is tangential to that.

Style nit: Skorch batch_size=-1 for the same functionality this PR implements (Skorch docstring). I think that's a little better because it mirrors the negative list indexing.

[adriangb]

I'm still a fan of keeping **kwargs in model.fit as expressed in #159 (comment). This PR is tangential to that.

Agreed, I don't plan on removing **kwargs just because this is implemented (if it is). Also tangential, but I'm going to punt a final decision on **kwargs down the road since I think some more use cases / user input would be good before making a decision either way.

-1 should work as well, I do like that it avoids introducing a new type to the parameter (str). Thanks for pointing this out.

[adriangb]

I think this change is pretty non-controversial, especially since Skorch already implements the exact same feature.

I'm going to leave this open a couple more days for feedback and then if there are no objections I'll go ahead and merge it.