Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Avoid patching the Keras Model if Keras alrady supports __reduce__ #248

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adriangb
Copy link
Owner

@adriangb adriangb commented Sep 6, 2021

This patching shouldn't be needed since keras-team/keras#14748 was merged, pending keras-team/keras#15300

@stsievert
Copy link
Collaborator

Requiring a higher version of Keras/TF is not a unreasonable approach. Maybe that can be done at some point in the future.

@adriangb
Copy link
Owner Author

adriangb commented Sep 7, 2021

yep, agreed, that may be a better alternative to this PR. I think next major release may be a good candidate.

@adriangb
Copy link
Owner Author

adriangb commented Nov 9, 2021

Well I opened keras-team/keras#252 to bump the versions.
Unfortunately, this PR is still not viable because we handle 2 things here which have still not been upstreamed:

So for now I am leaning towards bumping the versions in keras-team/keras#252 and then looping back here once/if the above issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants