Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sample_weight performance problem #285

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix sample_weight performance problem #285

wants to merge 2 commits into from

Conversation

richmanbtc
Copy link

@richmanbtc richmanbtc commented Oct 8, 2022 •
edited
Loading

Problem

Solution

  • Fixed to pass sample_weight to keras api in the correct way.

@adriangb
Copy link
Owner

So this "fix" makes legitimate tests fail. I'd also like to see a notebook showing performance degradation and how this fix addresses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richmanbtc @adriangb