Skip to content

Include all fields in cdr user edition and fix variant edition - #1069

Open
Rotheem wants to merge 2 commits into
mainfrom
fix-cdr-user-edition
Open

Include all fields in cdr user edition and fix variant edition#1069
Rotheem wants to merge 2 commits into
mainfrom
fix-cdr-user-edition

Conversation

@Rotheem

@Rotheem Rotheem commented Sep 2, 2026

Copy link
Copy Markdown
Member

Description

Summary

Fix 2 bugs in CDR edition

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@Rotheem
Rotheem force-pushed the fix-cdr-user-edition branch from 063379a to 50a8c3f Compare September 2, 2026 12:33
Comment thread app/modules/cdr/endpoints_cdr.py Outdated
Comment on lines +324 to +325
user_update=schemas_users.CoreUserUpdateAdmin(
**user_update.model_dump(exclude_unset=True),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this line. Are you sure?
For example, if user_update contains an email, won't the CoreUser's email be updated as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (4c3deab) to head (a3a7622).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   84.91%   84.91%           
=======================================
  Files         220      220           
  Lines       16358    16359    +1     
=======================================
+ Hits        13891    13892    +1     
  Misses       2467     2467           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants