Include all fields in cdr user edition and fix variant edition - #1069
Open
Rotheem wants to merge 2 commits into
Open
Include all fields in cdr user edition and fix variant edition#1069Rotheem wants to merge 2 commits into
Rotheem wants to merge 2 commits into
Conversation
Rotheem
force-pushed
the
fix-cdr-user-edition
branch
from
September 2, 2026 12:33
063379a to
50a8c3f
Compare
Comment on lines
+324
to
+325
| user_update=schemas_users.CoreUserUpdateAdmin( | ||
| **user_update.model_dump(exclude_unset=True), |
Member
There was a problem hiding this comment.
I'm not sure about this line. Are you sure?
For example, if user_update contains an email, won't the CoreUser's email be updated as well?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 220 220
Lines 16358 16359 +1
=======================================
+ Hits 13891 13892 +1
Misses 2467 2467 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fix 2 bugs in CDR edition
Issues/PR dependencies
Issues to be resolved
Required PRs
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
"Docstrings#Inline comments