-
Notifications
You must be signed in to change notification settings - Fork 6
Patch_Reviews_and_Commits
Previously we had a somewhat strict patch/review/ACK/push policy. We decided to relax it a bit. Note that this applies specifically to commiters only:
-
We assume anyone who posts a patch to the list, has successfully run an end-to-end test on it (or whatever is appropriate).
-
Trivial and obviously correct patches may be pushed without an ACK, but please do notify the list.
-
Reviewers are not required to apply and e2e test patches, b/c it can be assumed the author has already done so. If the patch is large, it is in the author’s interest to request review from an appropriate community member.
-
Reviewers should ensure that patches conform to our Coding-Guidelines as best as possible.
-
Authors who push patches that break tests will be slapped with a fish appropriate to the size of the violation