Add file dependencies to Git files #199
Conversation
| @@ -70,7 +70,7 @@ executable experiment | |||
| , core-text | |||
| , prettyprinter | |||
| , unordered-containers | |||
| buildable: False | |||
| buildable: True | |||
There was a problem hiding this comment.
This is just for testing, we can remove it after.
| @@ -98,7 +98,7 @@ program = do | |||
| info "Brr! It's cold" | |||
|
|
|||
| version :: Version | |||
| version = $(fromPackage) | |||
| version = $$fromPackage | |||
There was a problem hiding this comment.
This makes the package use the same system as githash itself, see the change in type signature in fromPackage.
There was a problem hiding this comment.
Is this a breaking change? Every single program built with this library uses fromPackage in its current form.
| resolver: lts-21.9 | ||
| compiler: ghc-9.4.6 |
There was a problem hiding this comment.
I updated the Stack snapshot.
|
@TheWizardTower do you think passing |
|
I think your approach is really good, and on reflection having to Changing from |
| Left _ -> pure Nothing | ||
| Right value -> do | ||
| runIO $ print (giFiles value) | ||
| addDependentFile "/home/juan/lol" |
There was a problem hiding this comment.
Heh, we need to patch this out :)
| -- but that's not happening. So more voodoo TH nonsense instead. | ||
|
|
||
| [e|result|] | ||
| fromPackage :: Code Q Version |
There was a problem hiding this comment.
We need a find to return this to being in the Q monad. I like that it returns a Version (far more explicit that :: Q Exp) but I don't want to break all the applications that do
version = $(fromPackage)right now.
This adds file dependencies to Git files in the TH code we had for getting versions. By itself, it didn't work as I expected. I wanted:
However, if we run with
--force-dirty, it seems to work well. That is, one should be able to choose when the version should reload or not.To test:
stack run unbeliever:exe:experiment --force-dirty -- --version, and see the current versionstack run unbeliever:exe:experiment --force-dirty -- --versionagain. The version should be different, and compatible with the new git commit.I left some comments in the code below.