Don't reset telemetry when forking a thread #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istathar
added
core-program
dmvianna
reviewed
Oct 12, 2023
|
@dmvianna added documentation about the behaviour and bumped version as requested. |
dmvianna
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
forkThreadto no longer fork the Datum object, as this had the result of silently discarding telemetry that the user thought they were adding to the in-flight enclosing spanAs discussed in
this is not ideal, so this branch changes this built in behaviour. The major version of core-program is bumped to 0.7.0 by way of signalling this change.
Closes #200