comments on potential flakiness

agrestio · Jul 9, 2024 · 090866a · 090866a
1 parent 464a7e0
commit 090866a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/...yenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java b/...yenne/src/main/java/io/agrest/cayenne/processor/select/ViaQueryWithParentExpResolver.java
@@ -84,6 +84,11 @@ public DataReader dataReader(RelatedResourceEntity<T> entity, ProcessingContext<
 
     protected void indexResultByParentId(RelatedResourceEntity<T> entity, List<Object[]> result) {
 
+        // implicit ID ordering ... It must match that of CayenneQueryAssembler.queryColumns, or the values will
+        // be assigned to the wrong columns.
+
+        // TODO: be extra paranoid and sort the key columns in both places?
+
         AgIdPart[] idAttributes = entity.getParent().getAgEntity().getIdParts().toArray(new AgIdPart[0]);
 
         for (Object[] row : result) {